Bug 41503

Summary: Implement processFakePEndTagIfPInScope
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Description Adam Barth 2010-07-01 22:20:29 PDT 
Implement processFakePEndTagIfPInScope
Comment 1 Adam Barth 2010-07-01 22:22:15 PDT 
Created attachment 60335 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-02 00:51:31 PDT 
Comment on attachment 60335 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:313
 +      if (!m_openElements.inScope(pTag.localName()))
This is sad.  We'll add a QualifiedName version.

WebCore/html/HTMLTreeBuilder.cpp:315
 +      AtomicHTMLToken endP(HTMLToken::EndTag, pTag.localName());
We need an function to handle this token creation for us.  I think AtomicHTMLTokens should be copyable and that would simplify a lot of this code.
Comment 3 WebKit Commit Bot 2010-07-02 03:26:38 PDT 
Comment on attachment 60335 [details]
Patch

Clearing flags on attachment: 60335

Committed r62376: <http://trac.webkit.org/changeset/62376>
Comment 4 WebKit Commit Bot 2010-07-02 03:26:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2010-07-02 18:58:13 PDT 
> This is sad.  We'll add a QualifiedName version.

Ok.

> WebCore/html/HTMLTreeBuilder.cpp:315
>  +      AtomicHTMLToken endP(HTMLToken::EndTag, pTag.localName());
> We need an function to handle this token creation for us.  I think AtomicHTMLTokens should be copyable and that would simplify a lot of this code.

I don't understand how copyable tokens would help here.  The P end tag gets invented out of whole cloth.