| Summary: | Make html5lib/runner dump failure details by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, ossy, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | 41439 | ||||||
| Bug Blocks: | 41123 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Seidel (no email)
2010-06-30 16:25:45 PDT
Created attachment 60169 [details]
Patch
Git gets confused and treats the results as binary. :( One can pass -a or --text to git diff to see the actual diff. Comment on attachment 60169 [details]
Patch
Ok... I'd like to see the actual results though.
Comment on attachment 60169 [details] Patch Rejecting patch 60169 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 255 Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. only literal type is supported now at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 248. Full output: http://webkit-commit-queue.appspot.com/results/3369091 Committed r62231: <http://trac.webkit.org/changeset/62231> http://trac.webkit.org/changeset/62231 might have broken Qt Linux Release The failures on the Qt bot show up as binary. :( So we may need to just roll this out if binary dumps are going to be a problem. We need to figure out which subtests are causing this file to be treated as binary. Reverted r62231 for reason: diff thinks runner-expected.txt is binary which makes the results impossible to read Committed r62232: <http://trac.webkit.org/changeset/62232> I found the root of the problem, line 222 is the culprit. diff say the expected file is binary because of "^@". Some non-printable char in the test1 output: Test 41 of 113 in resources/tests1.dat failed. Input: <! Got: | <!-- Somehow we're spitting out a \0 and not cactching it. Will fix. I believe it's due to BogusCommentState not handling EOF properly. I suspect this may be fixed by bug 41439. Committed r62237: <http://trac.webkit.org/changeset/62237> (In reply to comment #12) > I believe it's due to BogusCommentState not handling EOF properly. I knew BogusCommentState needed to come in from the cold! |