Summary: | make_names.pl should ignore pre-processor definitions when generating FooNames.* | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41123 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-06-30 16:09:21 PDT
Created attachment 60162 [details]
work in progress
You should generate names for the extra tags we need in the new tree builder too. This will require changes to make_names to make it ignore preprocessor definitions in the Names case, and not in the ElementFactory case. I'm not quite sure how to do that yet though. This is important for making a correctly functioning HTML5 TreeBuilder since it needs to respect "foreignObject" as a name, even if our foreignObject support is disabled. I'm not actively working on this bug atm, but we'll have to fix it before we can pass the entire libhtml5 test suite in all configurations. Block against master? |