| Summary: | Buildfix for !ENABLE(SVG_FOREIGN_OBJECT) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Patrick R. Gansterer
2010-06-30 14:25:00 PDT
Created attachment 60153 [details]
Patch
Attachment 60153 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTMLElementStack.cpp:165: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
We'll need to think about how to handle this case. Our parsing of a page shoudn't be different based on the value of that define. SVGNames should aways define foreignObject, even when it's not compiled in. This is the wrong fix. (In reply to comment #4) > SVGNames should aways define foreignObject, even when it's not compiled in. This is the wrong fix. even when support for foreignObject is not compiled in I mean. Comment on attachment 60153 [details] Patch Clearing flags on attachment: 60153 Committed r62208: <http://trac.webkit.org/changeset/62208> All reviewed patches have been landed. Closing bug. |