Bug 41429

Summary: Buildfix for !ENABLE(SVG_FOREIGN_OBJECT)
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2010-06-30 14:25:00 PDT
see patch
Attachments
Patch (1.11 KB, patch)
2010-06-30 14:26 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-06-30 14:26:35 PDT
Created attachment 60153 [details] Patch
WebKit Review Bot
Comment 2 2010-06-30 14:28:14 PDT
Attachment 60153 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTMLElementStack.cpp:165: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 3 2010-06-30 15:22:26 PDT
We'll need to think about how to handle this case. Our parsing of a page shoudn't be different based on the value of that define.
Eric Seidel (no email)
Comment 4 2010-06-30 15:24:10 PDT
SVGNames should aways define foreignObject, even when it's not compiled in. This is the wrong fix.
Eric Seidel (no email)
Comment 5 2010-06-30 15:24:32 PDT
(In reply to comment #4) > SVGNames should aways define foreignObject, even when it's not compiled in. This is the wrong fix. even when support for foreignObject is not compiled in I mean.
WebKit Commit Bot
Comment 6 2010-06-30 15:25:03 PDT
Comment on attachment 60153 [details] Patch Clearing flags on attachment: 60153 Committed r62208: <http://trac.webkit.org/changeset/62208>
WebKit Commit Bot
Comment 7 2010-06-30 15:25:08 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 8 2010-06-30 16:10:08 PDT
Filed bug 41433 for the proper fix.
Note You need to log in before you can comment on or make changes to this bug.