Bug 41324

Summary: Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser-only indended use
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dbates, eric, hyatt, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2010-06-28 18:41:28 PDT
Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser-only indended use
Attachments
Patch (14.67 KB, patch)
2010-06-28 18:44 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (22.93 KB, patch)
2010-06-28 19:07 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-28 18:44:11 PDT
Created attachment 59972 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-28 19:07:53 PDT
Created attachment 59975 [details] Patch
Adam Barth
Comment 3 2010-06-28 19:11:35 PDT
Comment on attachment 59975 [details] Patch ok. Thanks for doing this.
WebKit Commit Bot
Comment 4 2010-06-28 20:25:34 PDT
Comment on attachment 59975 [details] Patch Clearing flags on attachment: 59975 Committed r62079: <http://trac.webkit.org/changeset/62079>
WebKit Commit Bot
Comment 5 2010-06-28 20:25:39 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 6 2010-06-28 20:35:18 PDT
This broke the Qt Release bot. See <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/14207/steps/compile-webkit/logs/stdio>
WebKit Review Bot
Comment 7 2010-06-28 20:38:24 PDT
http://trac.webkit.org/changeset/62079 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release
Daniel Bates
Comment 8 2010-06-28 20:58:30 PDT
Attempt to fix the Qt bots committed in changeset 62081 <https://trac.webkit.org/changeset/62081>.
Note You need to log in before you can comment on or make changes to this bug.