Bug 41277

Summary: Don't dump contents of <script> elements in LayoutTests
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Description Adam Barth 2010-06-28 01:50:39 PDT
Don't dump contents of <script> elements in LayoutTests
Comment 1 Adam Barth 2010-06-28 01:53:05 PDT
Created attachment 59886 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-28 01:56:06 PDT
Comment on attachment 59886 [details]
Patch

Is this really the right place to call this?  We never re-push an element?

Seems like we should rename push and pop to somehting differnet in this case.
Comment 3 Adam Barth 2010-06-28 01:58:16 PDT
> Is this really the right place to call this?  We never re-push an element?

We don't yet.  There might be some crazy stuff in "reconstruct the formatting elements" though.

> Seems like we should rename push and pop to somehting differnet in this case.

Hum...  That's what it's called in the spec.  The spec don't talk about notifying the elements though.
Comment 4 WebKit Commit Bot 2010-06-28 02:56:42 PDT
Comment on attachment 59886 [details]
Patch

Clearing flags on attachment: 59886

Committed r61990: <http://trac.webkit.org/changeset/61990>
Comment 5 WebKit Commit Bot 2010-06-28 02:56:47 PDT
All reviewed patches have been landed.  Closing bug.