Bug 41276

Summary:

Make it possible to test the new HTML5 TreeBuilder

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41123

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Eric Seidel (no email) 2010-06-28 01:37:53 PDT

Make it possible to test the new HTML5 TreeBuilder

Comment 1 Eric Seidel (no email) 2010-06-28 01:39:52 PDT

Created attachment 59884 [details]
Patch

Comment 2 WebKit Review Bot 2010-06-28 01:41:41 PDT

Attachment 59884 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/page/Settings.h:304:  setHTML5TreeBuilderEnabled_DO_NOT_USE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Adam Barth 2010-06-28 01:42:35 PDT

Comment on attachment 59884 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:64
 +      return document && document->settings() && !document->settings()->html5TreeBuilderEnabled();
You should default the other way if we can't find the settings object

Comment 4 Eric Seidel (no email) 2010-06-28 01:52:30 PDT

Created attachment 59885 [details]
Patch for landing

Comment 5 WebKit Commit Bot 2010-06-28 02:44:47 PDT

Comment on attachment 59885 [details]
Patch for landing

Clearing flags on attachment: 59885

Committed r61989: <http://trac.webkit.org/changeset/61989>

Comment 6 WebKit Commit Bot 2010-06-28 02:44:53 PDT

All reviewed patches have been landed.  Closing bug.