Bug 41276 - Make it possible to test the new HTML5 TreeBuilder
Summary: Make it possible to test the new HTML5 TreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-06-28 01:37 PDT by Eric Seidel (no email)
Modified: 2010-06-30 16:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (13.60 KB, patch)
2010-06-28 01:39 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (13.71 KB, patch)
2010-06-28 01:52 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-28 01:37:53 PDT
Make it possible to test the new HTML5 TreeBuilder
Comment 1 Eric Seidel (no email) 2010-06-28 01:39:52 PDT
Created attachment 59884 [details]
Patch
Comment 2 WebKit Review Bot 2010-06-28 01:41:41 PDT
Attachment 59884 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/page/Settings.h:304:  setHTML5TreeBuilderEnabled_DO_NOT_USE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2010-06-28 01:42:35 PDT
Comment on attachment 59884 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:64
 +      return document && document->settings() && !document->settings()->html5TreeBuilderEnabled();
You should default the other way if we can't find the settings object
Comment 4 Eric Seidel (no email) 2010-06-28 01:52:30 PDT
Created attachment 59885 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-06-28 02:44:47 PDT
Comment on attachment 59885 [details]
Patch for landing

Clearing flags on attachment: 59885

Committed r61989: <http://trac.webkit.org/changeset/61989>
Comment 6 WebKit Commit Bot 2010-06-28 02:44:53 PDT
All reviewed patches have been landed.  Closing bug.