Bug 41265

Summary:

Clean up some loose ends in HTML5 tree builder

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41123

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Adam Barth 2010-06-27 12:36:01 PDT

Clean up some loose ends in HTML5 tree builder

Comment 1 Adam Barth 2010-06-27 12:41:13 PDT

Created attachment 59861 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-06-27 14:55:44 PDT

Comment on attachment 59861 [details]
Patch

WebCore/ChangeLog:17
 +              - Originally I thought that comments had speciall processing in the
special

WebCore/html/HTMLTreeBuilder.cpp:622
 +      currentElement()->addChild(HTMLElementFactory::createHTMLElement(QualifiedName(nullAtom, token.name(), xhtmlNamespaceURI), m_document, 0));
Seems we should wrap this in a function.  One which just takes the token.name().  createHTMLElement()?  addHTMLElement()?

Comment 3 Adam Barth 2010-06-27 16:04:08 PDT

Created attachment 59864 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2010-06-27 16:19:29 PDT

Comment on attachment 59864 [details]
Patch for landing

Clearing flags on attachment: 59864

Committed r61974: <http://trac.webkit.org/changeset/61974>

Comment 5 WebKit Commit Bot 2010-06-27 16:19:33 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 WebKit Review Bot 2010-06-27 16:50:22 PDT

http://trac.webkit.org/changeset/61974 might have broken GTK Linux 64-bit Debug