Bug 41239

Summary: We should parse <html>
Product: WebKit Reporter: Adam Barth <abarth>
Component: DOMAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Description Adam Barth 2010-06-25 17:30:35 PDT
We should parse <html>
Comment 1 Adam Barth 2010-06-25 17:34:28 PDT
Created attachment 59816 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-25 17:39:35 PDT
Comment on attachment 59816 [details]
Patch

OK.  rs=me.
Comment 3 Adam Barth 2010-06-25 17:48:09 PDT
Comment on attachment 59816 [details]
Patch

Clearing flags on attachment: 59816

Committed r61925: <http://trac.webkit.org/changeset/61925>
Comment 4 Adam Barth 2010-06-25 17:48:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2010-06-28 10:40:41 PDT
> This patch is hard to test 

Why is it hard to test? Won't an iframe pointing to such a document do it?

Or is it that HTMLTreeBuilder is in a state where nothing works yet?
Comment 6 Adam Barth 2010-06-28 10:46:15 PDT
> Why is it hard to test? Won't an iframe pointing to such a document do it?

You're presupposing that we could parse an <iframe> tag at this point.  Literally, this patch let us parse the document "<html>" and nothing else.

> Or is it that HTMLTreeBuilder is in a state where nothing works yet?

We're rapidly approaching the point where we can parse HTML5lib's runner.html.  At that point, adding tests will be easy.
Comment 7 Eric Seidel (no email) 2010-06-28 13:08:24 PDT
We actually cant' run the runner yet, but we're testing it it already:
https://trac.webkit.org/changeset/61989
https://trac.webkit.org/changeset/61991