Summary: | We should parse <html> | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | DOM | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41123 | ||||||
Attachments: |
|
Description
Adam Barth
2010-06-25 17:30:35 PDT
Created attachment 59816 [details]
Patch
Comment on attachment 59816 [details]
Patch
OK. rs=me.
Comment on attachment 59816 [details] Patch Clearing flags on attachment: 59816 Committed r61925: <http://trac.webkit.org/changeset/61925> All reviewed patches have been landed. Closing bug. > This patch is hard to test
Why is it hard to test? Won't an iframe pointing to such a document do it?
Or is it that HTMLTreeBuilder is in a state where nothing works yet?
> Why is it hard to test? Won't an iframe pointing to such a document do it? You're presupposing that we could parse an <iframe> tag at this point. Literally, this patch let us parse the document "<html>" and nothing else. > Or is it that HTMLTreeBuilder is in a state where nothing works yet? We're rapidly approaching the point where we can parse HTML5lib's runner.html. At that point, adding tests will be easy. We actually cant' run the runner yet, but we're testing it it already: https://trac.webkit.org/changeset/61989 https://trac.webkit.org/changeset/61991 |