Bug 41232

Summary:

HTMLTreeBuilder should branch first on token type and then on insertion mode

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, mike

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41123

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2010-06-25 15:56:45 PDT

HTMLTreeBuilder should branch first on token type and then on insertion mode

Comment 1 Adam Barth 2010-06-25 15:59:17 PDT

Created attachment 59807 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-06-25 16:02:13 PDT

Comment on attachment 59807 [details]
Patch

What are the ASSERTS for?
483     switch (insertionMode()) {
 484     case InitialMode:
 485         ASSERT(insertionMode() == InitialMode)

Comment 3 Eric Seidel (no email) 2010-06-25 16:05:42 PDT

Comment on attachment 59807 [details]
Patch

I think this is going to end up much nicer, yes.  Harder to compare the implementation to the spec though.  We may need to keep some sort of document as to implementation status to help us make sure we cover all the spec.

Comment 4 Adam Barth 2010-06-25 16:36:48 PDT

Comment on attachment 59807 [details]
Patch

Clearing flags on attachment: 59807

Committed r61915: <http://trac.webkit.org/changeset/61915>

Comment 5 Adam Barth 2010-06-25 16:36:53 PDT

All reviewed patches have been landed.  Closing bug.