Bug 41232 - HTMLTreeBuilder should branch first on token type and then on insertion mode
Summary: HTMLTreeBuilder should branch first on token type and then on insertion mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-06-25 15:56 PDT by Adam Barth
Modified: 2010-06-25 17:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (23.44 KB, patch)
2010-06-25 15:59 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-25 15:56:45 PDT 
HTMLTreeBuilder should branch first on token type and then on insertion mode
Comment 1 Adam Barth 2010-06-25 15:59:17 PDT 
Created attachment 59807 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-25 16:02:13 PDT 
Comment on attachment 59807 [details]
Patch

What are the ASSERTS for?
483     switch (insertionMode()) {
 484     case InitialMode:
 485         ASSERT(insertionMode() == InitialMode)
Comment 3 Eric Seidel (no email) 2010-06-25 16:05:42 PDT 
Comment on attachment 59807 [details]
Patch

I think this is going to end up much nicer, yes.  Harder to compare the implementation to the spec though.  We may need to keep some sort of document as to implementation status to help us make sure we cover all the spec.
Comment 4 Adam Barth 2010-06-25 16:36:48 PDT 
Comment on attachment 59807 [details]
Patch

Clearing flags on attachment: 59807

Committed r61915: <http://trac.webkit.org/changeset/61915>
Comment 5 Adam Barth 2010-06-25 16:36:53 PDT 
All reviewed patches have been landed.  Closing bug.