Bug 41199

Summary:

[Qt] QtScript API should be exceptions aware.

Product:

WebKit

Reporter:

Jędrzej Nowacki <jedrzej.nowacki>

Component:

JavaScriptCore

Assignee:

Jędrzej Nowacki <jedrzej.nowacki>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, hausmann, kent.hansen

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

31863

Attachments:

Description	Flags
Fix v1	none
Fix v1.01	hausmann: review+, commit-queue: commit-queue-

Description Jędrzej Nowacki 2010-06-25 01:17:02 PDT

The QtScript API should be enriched by these functions:

http://doc.qt.nokia.com/4.6/qscriptengine.html#clearExceptions
http://doc.qt.nokia.com/4.6/qscriptengine.html#hasUncaughtException
http://doc.qt.nokia.com/4.6/qscriptengine.html#uncaughtException

Comment 1 Jędrzej Nowacki 2010-06-28 05:52:14 PDT

Created attachment 59895 [details]
Fix v1

Comment 2 Kent Hansen 2010-06-28 07:36:38 PDT

LGTM

Comment 3 Jędrzej Nowacki 2010-06-29 01:37:45 PDT

Comment on attachment 59895 [details]
Fix v1

Patch need to be rebased.

Comment 4 Jędrzej Nowacki 2010-06-30 04:21:50 PDT

Created attachment 60108 [details]
Fix v1.01

Rebased against trunk.

Comment 5 Simon Hausmann 2010-07-02 01:25:54 PDT

Comment on attachment 60108 [details]
Fix v1.01

r=me

Comment 6 WebKit Commit Bot 2010-07-02 01:43:49 PDT

Comment on attachment 60108 [details]
Fix v1.01

Rejecting patch 60108 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60108, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
webkitpy/tool/commands/stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 68, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Comment 7 Simon Hausmann 2010-07-02 03:39:01 PDT

Committed r62377: <http://trac.webkit.org/changeset/62377>