Bug 41184

Summary: Sketch out InHeadMode for tree builder
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Description Adam Barth 2010-06-24 17:01:06 PDT
Sketch out InHeadMode for tree builder
Comment 1 Adam Barth 2010-06-24 17:03:21 PDT
Created attachment 59711 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-24 22:22:31 PDT
Comment on attachment 59711 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:358
 +              // FIXME: Atomize "command".
Silly fixme.  DEFINE_LOCAL(AtomicString, commandAtom, "command") is all you need. :)

Yeah, this is going to be the wrong design.  We're going to want to switch based on tag and then on state, instead of how the spec is written which is state then tag.WebCore/html/HTMLTreeBuilder.cpp:400
 +              break;
This break seems silly.
Comment 3 Adam Barth 2010-06-24 22:33:46 PDT
Comment on attachment 59711 [details]
Patch

Clearing flags on attachment: 59711

Committed r61823: <http://trac.webkit.org/changeset/61823>
Comment 4 Adam Barth 2010-06-24 22:33:51 PDT
All reviewed patches have been landed.  Closing bug.