Bug 41131

Summary: Add AtomicHTMLToken
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2010-06-23 23:14:21 PDT
Add AtomicHTMLToken
Attachments
Patch (8.41 KB, patch)
2010-06-23 23:17 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-23 23:17:00 PDT
Created attachment 59614 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-23 23:20:15 PDT
Comment on attachment 59614 [details] Patch I like the idea. It should have its own header though. It could be a subclass of HTMLToken, but I think it's nice to be separate like this. HTMLToken may end up being a struct and internal to the Tokenizer as you suggest. I'm ready to r+ this, but I think it needs its own header.
Adam Barth
Comment 3 2010-06-23 23:23:41 PDT
> It could be a subclass of HTMLToken, but I think it's nice to be separate like this. HTMLToken may end up being a struct and internal to the Tokenizer as you suggest. It can't be a subclass because we don't want the large buffers that HTMLToken has. > I'm ready to r+ this, but I think it needs its own header. I could add a separate header, but it's eventually going to eat HTMLToken, so there doesn't seem to be much of a point in adding a new header.
Eric Seidel (no email)
Comment 4 2010-06-23 23:32:00 PDT
(In reply to comment #3) > > It could be a subclass of HTMLToken, but I think it's nice to be separate like this. HTMLToken may end up being a struct and internal to the Tokenizer as you suggest. > > It can't be a subclass because we don't want the large buffers that HTMLToken has. Agreed. > > I'm ready to r+ this, but I think it needs its own header. > > I could add a separate header, but it's eventually going to eat HTMLToken, so there doesn't seem to be much of a point in adding a new header. I don't believe you.
Eric Seidel (no email)
Comment 5 2010-06-23 23:32:18 PDT
Comment on attachment 59614 [details] Patch I think your lack-of-new-header is mostly being lazy. :p
Adam Barth
Comment 6 2010-06-24 15:07:59 PDT
Committed r61791: <http://trac.webkit.org/changeset/61791>
Note You need to log in before you can comment on or make changes to this bug.