Bug 41108

Summary: A buffer should be bound to one target in its lifetime
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, kbr, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41092    
Attachments:
Description Flags
patch
none
revised patch : responding to kbr's review
none
revised patch: fixed the typo none

Zhenyao Mo
Reported 2010-06-23 15:21:05 PDT
In WebGL, an attempt to bind a buffer to another target will generate INVALID_OPERATION.
Attachments
patch (16.55 KB, patch)
2010-06-23 15:25 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
revised patch : responding to kbr's review (17.21 KB, patch)
2010-06-23 17:37 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
revised patch: fixed the typo (17.21 KB, patch)
2010-06-24 09:40 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-06-23 15:25:48 PDT
Created attachment 59568 [details] patch
Kenneth Russell
Comment 2 2010-06-23 17:22:52 PDT
Comment on attachment 59568 [details] patch Generally looks good. One comment which will require another revision. WebCore/html/canvas/WebGLBuffer.h:71 + unsigned m_arrayBufferByteLength; These two byte lengths can be collapsed into one now. This should simplify the logic above.
Zhenyao Mo
Comment 3 2010-06-23 17:37:03 PDT
Created attachment 59587 [details] revised patch : responding to kbr's review
Kenneth Russell
Comment 4 2010-06-23 17:49:26 PDT
Comment on attachment 59587 [details] revised patch : responding to kbr's review This looks good; nice cleanup. However I just noticed there's a typo in one comment which makes it really confusing. WebCore/html/canvas/WebGLBuffer.cpp:149 + // In WebGL, a buffer is bound to its target in its lifetime should read "one target in its lifetime"
Zhenyao Mo
Comment 5 2010-06-24 09:40:08 PDT
Created attachment 59664 [details] revised patch: fixed the typo
Dimitri Glazkov (Google)
Comment 6 2010-06-24 09:54:12 PDT
Comment on attachment 59664 [details] revised patch: fixed the typo ok.
WebKit Commit Bot
Comment 7 2010-06-25 19:47:55 PDT
Comment on attachment 59664 [details] revised patch: fixed the typo Clearing flags on attachment: 59664 Committed r61934: <http://trac.webkit.org/changeset/61934>
WebKit Commit Bot
Comment 8 2010-06-25 19:48:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.