Bug 40922

Summary: Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adachan, andersca, eric, sfalken, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on: 40921    
Bug Blocks:    
Attachments:
Description Flags
Patch mjs: review+

Adam Roben (:aroben)
Reported 2010-06-21 08:33:44 PDT
We should make WebKit2 be built by build-webkit so it will be built by the build.webkit.org bots. One way to do this is to add WebKit2 to WebKit.sln (though that's a little confusing, since WebKit and WebKit2 are peers).
Attachments
Patch (40.96 KB, patch)
2010-07-12 23:18 PDT, Steve Falkenburg 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-06-21 08:34:31 PDT
We probably shouldn't do this until bug 40921 is fixed, as otherwise WebKit2 will take just as long to link as WebKit1, which could slow down the bots a lot.
Adam Roben (:aroben)
Comment 2 2010-06-21 08:35:15 PDT
<rdar://problem/8113039>
Steve Falkenburg
Comment 3 2010-07-12 23:18:49 PDT
Created attachment 61334 [details] Patch
Maciej Stachowiak
Comment 4 2010-07-12 23:21:04 PDT
Comment on attachment 61334 [details] Patch r=me
Steve Falkenburg
Comment 5 2010-07-12 23:32:57 PDT
Committed r63178: <http://trac.webkit.org/changeset/63178>
WebKit Review Bot
Comment 6 2010-07-13 00:39:48 PDT
http://trac.webkit.org/changeset/63178 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63178 http://trac.webkit.org/changeset/63179 http://trac.webkit.org/changeset/63180 http://trac.webkit.org/changeset/63181
Note You need to log in before you can comment on or make changes to this bug.