Summary: | [Qt] QScriptValue should have API for accessing object properties | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Hansen <kent.hansen> | ||||||
Component: | WebKit Qt | Assignee: | Jędrzej Nowacki <jedrzej.nowacki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, cmarcelo, commit-queue, eric, jedrzej.nowacki, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 40613 | ||||||||
Bug Blocks: | 31863 | ||||||||
Attachments: |
|
Description
Kent Hansen
2010-06-21 00:53:08 PDT
Created attachment 59336 [details]
Partial patch v1
This implements just the ResolvePrototype case for property(), still need to dig the C API for a way to get the own property only. However, as is, it's already useful to enhance our tests of other features.
(In reply to comment #1) > Created an attachment (id=59336) [details] > Partial patch v1 > > This implements just the ResolvePrototype case for property(), still need to dig the C API for a way to get the own property only. However, as is, it's already useful to enhance our tests of other features. Looks good to me :-). Next time we should be more in sync as I have a patch for this bug (it contains setProperty too). I will rebase mine after yours will be applied. Thanks! Comment on attachment 59336 [details] Partial patch v1 Clearing flags on attachment: 59336 Committed r62007: <http://trac.webkit.org/changeset/62007> All reviewed patches have been landed. Closing bug. Thanks, folks. But we probably should keep this bugs open so Jędrzej can land the other patch. :-) (In reply to comment #5) > Thanks, folks. But we probably should keep this bugs open so Jędrzej can land the other patch. :-) yes, it would be nice ;-) Created attachment 60600 [details]
Fix v2
I added setProperty() and a few additional flags
(In reply to comment #7) > Created an attachment (id=60600) [details] > Fix v2 > > I added setProperty() and a few additional flags Looks good! Comment on attachment 60600 [details]
Fix v2
Great testing as always.
Comment on attachment 60600 [details] Fix v2 Clearing flags on attachment: 60600 Committed r62547: <http://trac.webkit.org/changeset/62547> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/62547 might have broken GTK Linux 64-bit Debug |