Bug 40559

Summary: Refactor layout tests for printing to use common code.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: PrintingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hamaji, hayato, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
refactor-layouttests-for-printing
none
refactor-layouttests-for-printing-fix-output-order hamaji: review+

Hayato Ito
Reported 2010-06-14 01:33:17 PDT
Refactor layout tests for printing to use common code. Layout tests in printing/css2.1/ uses LayoutTests/printing/resources/page-media-test-utils.js, but other tests in printing don't use that JS. It is better to share code between them.
Attachments
refactor-layouttests-for-printing (28.98 KB, patch)
2010-06-14 01:38 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
refactor-layouttests-for-printing-fix-output-order (29.86 KB, patch)
2010-06-14 05:43 PDT, Hayato Ito 		hamaji: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2010-06-14 01:38:52 PDT
Created attachment 58627 [details] refactor-layouttests-for-printing
Hayato Ito
Comment 2 2010-06-14 01:49:03 PDT
FYI. The patch is splitted from the following patch, including only refactoring and some minor refinements. https://bugs.webkit.org/show_bug.cgi?id=39735 https://bug-39735-attachments.webkit.org/attachment.cgi?id=57215
Shinichiro Hamaji
Comment 3 2010-06-14 04:13:36 PDT
Comment on attachment 58627 [details] refactor-layouttests-for-printing LayoutTests/printing/numberOfPages-expected.txt:10 + PASS: number of pages is 2 It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?
Hayato Ito
Comment 4 2010-06-14 05:43:59 PDT
Created attachment 58638 [details] refactor-layouttests-for-printing-fix-output-order
Hayato Ito
Comment 5 2010-06-14 05:46:41 PDT
Sure. I've changed the order of the execution. Could you review it? (In reply to comment #3) > (From update of attachment 58627 [details]) > LayoutTests/printing/numberOfPages-expected.txt:10 > + PASS: number of pages is 2 > It's not good to have messages after "TEST COMPLETE". Cannot we avoid this? (In reply to comment #3) > (From update of attachment 58627 [details]) > LayoutTests/printing/numberOfPages-expected.txt:10 > + PASS: number of pages is 2 > It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?
Shinichiro Hamaji
Comment 6 2010-06-14 05:55:17 PDT
Comment on attachment 58638 [details] refactor-layouttests-for-printing-fix-output-order Looks good to me. Thanks for updating!
Shinichiro Hamaji
Comment 7 2010-06-17 00:00:35 PDT
Committed r61309: <http://trac.webkit.org/changeset/61309>
Daniel Bates
Comment 8 2010-07-23 22:17:52 PDT
Comment on attachment 58638 [details] refactor-layouttests-for-printing-fix-output-order Clearing commit-queue flag to get this out of the commit-queue.
Note You need to log in before you can comment on or make changes to this bug.