Bug 40428

Summary: Update acid3 test with latest from acid3.acidtests.org
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: Tools / TestsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Patch none

Tony Gentilcore
Reported 2010-06-10 10:20:08 PDT
Update acid3 test with latest from acid3.acidtests.org
Attachments
Patch (106.31 KB, patch)
2010-06-10 10:25 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-06-10 10:25:52 PDT
Created attachment 58383 [details] Patch
Tony Gentilcore
Comment 2 2010-06-10 10:27:08 PDT
Incidentally this updated version passes with --html5-parser set, however the expectations were generated without it.
Adam Barth
Comment 3 2010-06-10 10:38:16 PDT
Comment on attachment 58383 [details] Patch Thanks! LayoutTests/http/tests/misc/acid3.html:2477 + assertEquals(doc.firstChild.name.toUpperCase(), "HTML", "name wrong (first test)"); // changed 2009-08-13 to add .toUpperCase() for HTML5 compat Ah, this is probably the change we needed.
WebKit Commit Bot
Comment 4 2010-06-11 02:10:29 PDT
Comment on attachment 58383 [details] Patch Clearing flags on attachment: 58383 Committed r60999: <http://trac.webkit.org/changeset/60999>
WebKit Commit Bot
Comment 5 2010-06-11 02:10:34 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2010-06-11 09:40:53 PDT
Why are we failing the linktest? Comments in test code seem to indicate that it's supposed to work with :visited privacy changes now.
Tony Gentilcore
Comment 7 2010-06-11 09:49:03 PDT
(In reply to comment #6) > Why are we failing the linktest? Comments in test code seem to indicate that it's supposed to work with :visited privacy changes now. Not sure. The goal of this patch was just to update to the latest version of the test. The ChangeLog mentions that the same error persists through this patch, it is only the display of the error message that changed. Probably a good idea to open a separate bug for the failure if there isn't one already.
Note You need to log in before you can comment on or make changes to this bug.