Summary: | Fix fast/parser/hex-entities-length.html for HTML5 parser | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||
Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ian | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 39259 | ||||||
Attachments: |
|
Description
Tony Gentilcore
2010-06-09 12:46:02 PDT
Created attachment 58281 [details]
Patch
Minefield passes this test, and it appears that if the "Preprocessing the input stream" spec were strictly followed it could not pass the test. Also, I poked around at the minefield implementation and found where these character ranges are replaced for entities (in handleNcrValue). But can't find anywhere where they are replaced in the input stream itself (they are just passed to emitOrAppendTwo). Links: http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5Tokenizer.cpp http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5StreamParser.cpp Comment on attachment 58281 [details]
Patch
Yep. This will fix a bunch of tests, actually.
Can you email public-html with this feedback on the spec?
Comment on attachment 58281 [details] Patch Clearing flags on attachment: 58281 Committed r60916: <http://trac.webkit.org/changeset/60916> All reviewed patches have been landed. Closing bug. |