Bug 40120

Summary: [Qt] QScriptValue should have an instanceOf method
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jedrzej.nowacki, kenneth
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31863    
Attachments:
Description Flags
Fix v1
kenneth: review+
Fix v1.01 none

Jędrzej Nowacki
Reported 2010-06-03 07:04:54 PDT
The QScriptValue should have an instancOf method, something like: http://doc.trolltech.com/4.6/qscriptvalue.html#instanceOf
Attachments
Fix v1 (7.93 KB, patch)
2010-06-03 07:13 PDT, Jędrzej Nowacki 		kenneth: review+
DetailsFormatted DiffDiff
Fix v1.01 (7.97 KB, patch)
2010-06-04 03:28 PDT, Jędrzej Nowacki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jędrzej Nowacki
Comment 1 2010-06-03 07:13:55 PDT
Created attachment 57764 [details] Fix v1
Kenneth Rohde Christiansen
Comment 2 2010-06-03 09:40:52 PDT
Comment on attachment 57764 [details] Fix v1 JavaScriptCore/qt/api/qscriptvalue.cpp:590 + Returns true if this QScriptValue is an instance of Is the indentation correct here? It is supposed to be 4.
Jędrzej Nowacki
Comment 3 2010-06-04 03:28:53 PDT
Created attachment 57860 [details] Fix v1.01 (In reply to comment #2) > (From update of attachment 57764 [details]) > JavaScriptCore/qt/api/qscriptvalue.cpp:590 > + Returns true if this QScriptValue is an instance of > Is the indentation correct here? It is supposed to be 4. Fixed.
WebKit Commit Bot
Comment 4 2010-06-04 17:23:23 PDT
Comment on attachment 57860 [details] Fix v1.01 Clearing flags on attachment: 57860 Committed r60725: <http://trac.webkit.org/changeset/60725>
WebKit Commit Bot
Comment 5 2010-06-04 17:23:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.