Bug 39960

Summary: Broken code generated in GenerateParametersCheckExpressions
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39962    
Attachments:
Description Flags
Proposed patch
none
Proposed patch v2 none

Andreas Kling
Reported 2010-05-31 10:16:11 PDT
The code generated by CodeGeneratorJS.pm (line 1117) will not compile.
Attachments
Proposed patch (1.37 KB, patch)
2010-05-31 10:17 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch v2 (3.23 KB, patch)
2010-06-01 04:49 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-05-31 10:17:20 PDT
Created attachment 57478 [details] Proposed patch
Darin Adler
Comment 2 2010-05-31 10:19:56 PDT
Comment on attachment 57478 [details] Proposed patch I was about to say review+, but what about adding a test case? Adam Barth has kindly provided us with the run-bindings-tests script. You can add additional test cases to the IDL files in the WebCore/bindings/scripts/test directory, and then use "run-bindings-tests" to see the generated results, then use run-bindings-test --reset-results to generate files that are ready to check in once yu've verified the code is correct.
Andreas Kling
Comment 3 2010-06-01 04:49:51 PDT
Created attachment 57530 [details] Proposed patch v2 Right-o, I was not aware of the bindings tests. :-) Turns out there was already coverage (with a broken reference result.)
WebKit Commit Bot
Comment 4 2010-06-01 19:38:56 PDT
Comment on attachment 57530 [details] Proposed patch v2 Clearing flags on attachment: 57530 Committed r60527: <http://trac.webkit.org/changeset/60527>
WebKit Commit Bot
Comment 5 2010-06-01 19:39:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.