Bug 39960

Summary:

Broken code generated in GenerateParametersCheckExpressions

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

39962

Attachments:

Description	Flags
Proposed patch	none
Proposed patch v2	none

Description Andreas Kling 2010-05-31 10:16:11 PDT

The code generated by CodeGeneratorJS.pm (line 1117) will not compile.

Comment 1 Andreas Kling 2010-05-31 10:17:20 PDT

Created attachment 57478 [details]
Proposed patch

Comment 2 Darin Adler 2010-05-31 10:19:56 PDT

Comment on attachment 57478 [details]
Proposed patch

I was about to say review+, but what about adding a test case?

Adam Barth has kindly provided us with the run-bindings-tests script. You can add additional test cases to the IDL files in the WebCore/bindings/scripts/test directory, and then use "run-bindings-tests" to see the generated results, then use run-bindings-test --reset-results to generate files that are ready to check in once yu've verified the code is correct.

Comment 3 Andreas Kling 2010-06-01 04:49:51 PDT

Created attachment 57530 [details]
Proposed patch v2

Right-o, I was not aware of the bindings tests. :-)
Turns out there was already coverage (with a broken reference result.)

Comment 4 WebKit Commit Bot 2010-06-01 19:38:56 PDT

Comment on attachment 57530 [details]
Proposed patch v2

Clearing flags on attachment: 57530

Committed r60527: <http://trac.webkit.org/changeset/60527>

Comment 5 WebKit Commit Bot 2010-06-01 19:39:03 PDT

All reviewed patches have been landed.  Closing bug.