| Summary: | Handle edge cases in HTML5 entity parsing | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 39259 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2010-05-27 02:34:05 PDT
Created attachment 57213 [details]
Work in progress
Created attachment 57312 [details]
Patch
Comment on attachment 57312 [details]
Patch
Should we rip entity handling out into its own class and share code between this and the old tok?
I see a bunch of new failures. I guess this adds a bunch of tests but doesn't fix them all?
> Should we rip entity handling out into its own class and share code between this and the old tok? The problem is that entity handling depends on the state of the lexer. We could abstract that if we wanted to, however. > I see a bunch of new failures. I guess this adds a bunch of tests but doesn't fix them all? Those are failures in the existing parser. The new parser passes all the new tests. (There are two existing entity tests that fail in both the old and new parser, but that's another story.) Committed r60369: <http://trac.webkit.org/changeset/60369> http://trac.webkit.org/changeset/60369 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/60368 http://trac.webkit.org/changeset/60369 http://trac.webkit.org/changeset/60370 http://trac.webkit.org/changeset/60366 http://trac.webkit.org/changeset/60367 |