Bug 39823

Summary: Handle edge cases in HTML5 entity parsing
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Work in progress
none
Patch eric: review+

Adam Barth
Reported 2010-05-27 02:34:05 PDT
Handle edge cases in HTML5 entity parsing
Attachments
Work in progress (12.29 KB, patch)
2010-05-27 02:38 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (13.03 KB, patch)
2010-05-28 03:37 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-27 02:38:59 PDT
Created attachment 57213 [details] Work in progress
Adam Barth
Comment 2 2010-05-28 03:37:05 PDT
Created attachment 57312 [details] Patch
Eric Seidel (no email)
Comment 3 2010-05-28 10:14:26 PDT
Comment on attachment 57312 [details] Patch Should we rip entity handling out into its own class and share code between this and the old tok? I see a bunch of new failures. I guess this adds a bunch of tests but doesn't fix them all?
Adam Barth
Comment 4 2010-05-28 10:46:00 PDT
> Should we rip entity handling out into its own class and share code between this and the old tok? The problem is that entity handling depends on the state of the lexer. We could abstract that if we wanted to, however. > I see a bunch of new failures. I guess this adds a bunch of tests but doesn't fix them all? Those are failures in the existing parser. The new parser passes all the new tests. (There are two existing entity tests that fail in both the old and new parser, but that's another story.)
Adam Barth
Comment 5 2010-05-28 11:17:20 PDT
Committed r60369: <http://trac.webkit.org/changeset/60369>
Note You need to log in before you can comment on or make changes to this bug.