Bug 39649

Summary: First cut at HTML5 entities
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, Ms2ger, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Patch eric: review+

Description Adam Barth 2010-05-24 23:35:32 PDT 
First cut at HTML5 entities
Comment 1 Adam Barth 2010-05-24 23:38:26 PDT 
Created attachment 56977 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-24 23:39:52 PDT 
Attachment 56977 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTML5Lexer.cpp:88:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-05-24 23:44:40 PDT 
Comment on attachment 56977 [details]
Patch

LGTM.  Style?
Comment 4 Adam Barth 2010-05-24 23:47:25 PDT 
Committed r60130: <http://trac.webkit.org/changeset/60130>
Comment 5 Ms2ger (he/him; ⌚ UTC+1/+2) 2010-05-25 00:38:54 PDT 
s/uncomsumeCharacters/unconsumeCharacters/g?