| Summary: | webkit-patch should support CHANGE_LOG_EDIT_APPLICATION | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2010-05-22 16:11:58 PDT
Created attachment 56796 [details]
Patch
Comment on attachment 56796 [details]
Patch
I'm not sure searching for xcode is a good idea. Is xed specific to xcode? In any case Darin Adler should probably review this since this was his request and it might be good for him to see where this code is anyway. :) the python otherwise looked ok to me.
I think xed is specific to Xcode.
$ xed --help
Options:
-x, --launch Just launch Xcode with a new untitled document, don't wait on stdin.
-c, --create Create the files if they do not exist.
-w, --wait Wait for file to be closed by Xcode.
-l, --line <number> Select line <number> after opening file. Takes effect only on last file opened.
-b, --background Leave Xcode as a background app after opening.
-n, --no-reactivation After edit with -w, do not re-activate the calling app.
-h, --help Show this information.
-v, --version Print version information.
Comment on attachment 56796 [details]
Patch
Looks good to me.
I know Eric said that it may be good for Darin to look it over but I suspect he has plenty of time to do so by now -- especially given his prodigious review rate, and I'd like to shrink the review queue some. :)
Comment on attachment 56796 [details]
Patch
Thanks!
Comment on attachment 56796 [details] Patch Clearing flags on attachment: 56796 Committed r60384: <http://trac.webkit.org/changeset/60384> All reviewed patches have been landed. Closing bug. I now regret asking for this! EDITOR set to "xed --wait" gives me great results with webkit-patch. CHANGE_LOG_EDIT_APPLICATION is still needed to give me good results with prepare-ChangeLog. Yet if I have both set, then webkit-patch uses CHANGE_LOG_EDIT_APPLICATION instead of EDITOR. That's frustrating. Maybe we should just roll this out? Or maybe we should teach prepare-ChangeLog to use EDITOR? But in that script there is no real benefit to waiting. Any other suggestions? I'm happy to do whatever you'd prefer. Sorry for causing trouble. :( (In reply to comment #9) > I'm happy to do whatever you'd prefer. Sorry for causing trouble. :( I really appreciate you doing to the trouble of adding this. I think it’s probably best to just roll it out again, because there’s probably no one except me who wants it, and setting EDITOR to "xed --launch --wait" is really good for people who want to use Xcode. By the way, it does need to be “xed --launch --wait”, not just “xed --wait”. Follow up in https://bugs.webkit.org/show_bug.cgi?id=40088 |