Bug 39472

Summary: [GStreamer] multiple video sink support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, slomo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 39474, 39740    
Bug Blocks: 39202    
Attachments:
Description Flags
proposed patch gustavo: review+

Philippe Normand
Reported 2010-05-20 23:27:02 PDT
For video fullscreen support it would be nice if the player could do the rendering using autovideosink. This requires the current playbin2 video-sink to be a bin internally rendering to the webkit videosink and, when needed for fullscreen, autovideosink. For this to work on application-side, gst XOverlay support is also needed in GStreamerGWorld, otherwise autovideosink (on gtk port) will internally create and show an X11 window.
Attachments
proposed patch (7.11 KB, patch)
2010-05-28 10:01 PDT, Philippe Normand 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-05-28 10:01:22 PDT
Created attachment 57337 [details] proposed patch
Philippe Normand
Comment 2 2010-06-01 10:37:24 PDT
Sebastian, can you have a look at the patch when you get some time please? :)
Sebastian Dröge (slomo)
Comment 3 2010-06-03 01:11:35 PDT
Looks good, yes
Philippe Normand
Comment 4 2010-06-22 00:57:30 PDT
Gustavo, would you have time to take a look? Bug 39474 too if possible. Sebastian did one pass on the patches already, some time ago :)
Gustavo Noronha (kov)
Comment 5 2010-06-24 06:49:19 PDT
Comment on attachment 57337 [details] proposed patch It looks very good to me. The only improvement I suggest is not creating member variables for the queue and the tee. They are completely useless - you are not even using them when enabling fullscreen, so just make them variables scoped to the createGSTPlayBin function, please, unless you have a good reason to keep them. I would prefer having more descriptive names for the queue and tee elements, too "t" does the job, but we can do better, I guess? =)
Philippe Normand
Comment 6 2010-06-25 00:07:08 PDT
Landed as http://trac.webkit.org/changeset/61834 with the suggested fixes. Thanks for the review :)
Note You need to log in before you can comment on or make changes to this bug.