Bug 39356

Summary: [Qt] QScriptValue should have accessors to a prototype.
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, commit-queue, eric, jedrzej.nowacki, kent.hansen, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 40060, 39360    
Bug Blocks: 31863    
Attachments:
Description Flags
Fix v1 none

Jędrzej Nowacki
Reported 2010-05-19 06:41:46 PDT
The QScriptValue should have an API to set/get prototype of the value. It should look like this: http://doc.trolltech.com/4.6/qscriptvalue.html#setPrototype http://doc.trolltech.com/4.6/qscriptvalue.html#prototype
Attachments
Fix v1 (7.74 KB, patch)
2010-06-22 04:40 PDT, Jędrzej Nowacki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jędrzej Nowacki
Comment 1 2010-06-22 04:40:32 PDT
Created attachment 59360 [details] Fix v1 The accessors are needed to test other QtScript functionality (like a newArray). So I decided to implement them in a suboptimal way. We can fix it as result of discussion on bug 40060 would be known.
WebKit Commit Bot
Comment 2 2010-06-25 06:39:32 PDT
Comment on attachment 59360 [details] Fix v1 Clearing flags on attachment: 59360 Committed r61860: <http://trac.webkit.org/changeset/61860>
WebKit Commit Bot
Comment 3 2010-06-25 06:39:37 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-06-25 07:23:42 PDT
http://trac.webkit.org/changeset/61860 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.