Bug 39298

Summary:

Implement two more lexer states

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

39259

Attachments:

Description	Flags
Patch	eric: review+

Adam Barth

Reported 2010-05-18 10:17:31 PDT

Implement two more lexer states

Attachments
Patch (3.59 KB, patch) 2010-05-18 10:18 PDT, Adam Barth	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-05-18 10:18:49 PDT

Created attachment 56387 [details] Patch

WebKit Review Bot

Comment 2 2010-05-18 10:21:13 PDT

Attachment 56387 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTML5Lexer.cpp:661: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 3 2010-05-18 11:17:58 PDT

Comment on attachment 56387 [details] Patch rs=me.

Adam Barth

Comment 4 2010-05-18 16:55:52 PDT

Committed r59720: <http://trac.webkit.org/changeset/59720>

Note You need to log in before you can comment on or make changes to this bug.