Bug 39277
| Summary: | [Qt] QtScript's JavaScriptCore "out of sync" with QtWebKit's | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | vanboxem.ruben |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | benjamin, hausmann, kent.hansen |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
vanboxem.ruben
The files wtf/Platform.h and runtime/Collector.cpp in Qt/src/3rdparty/javascriptcore/JavaScriptCore/ are out of sync with the files in WebKit trunk (and the ones in Qt/src/3rdparty/webkit/JavaScriptCore). How this happened, I don't know, but the update is necessary for QtScript to build with mingw-w32 (<->mingw.org).
I tried a Qt merge request(http://qt.gitorious.org/qt/qt/merge_requests/2391), but it seems all has to come through here. The merge request has the needed patch to apply the necessary changes to both files.
PS: this is not the "blocker" Win64 JIT bug, this change is from before that. This was the second of the patches applied here: https://bugs.webkit.org/show_bug.cgi?id=35607 (the ... - JavaScriptCore one). Also, the blocker bug has been closed automatically because all the attached patches were landed, the JIT Win64 bug is here now: https://bugs.webkit.org/show_bug.cgi?id=38993 and hesn't been added to the blockers list (is it supposed to be?)
Thanks
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Hausmann
This is not blocker for the QtWebKit release, src/3rdparty/javascriptcore is maintained separately.
Benjamin Poulain
Kent, is this solved? Can I close this task?
vanboxem.ruben
http://bugreports.qt.nokia.com/browse/QTBUG-10723
The files seem ok to me
Benjamin Poulain
(In reply to comment #3)
> http://bugreports.qt.nokia.com/browse/QTBUG-10723
>
> The files seem ok to me
Cool, closing then.