Bug 39274

Summary: Add an HTML5Token
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Patch
none
Patch eric: review+

Adam Barth
Reported 2010-05-18 01:49:03 PDT
Add an HTML5Token
Attachments
Patch (9.01 KB, patch)
2010-05-18 01:51 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (9.02 KB, patch)
2010-05-18 01:54 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-18 01:51:32 PDT
Created attachment 56336 [details] Patch
WebKit Review Bot
Comment 2 2010-05-18 01:53:45 PDT
Attachment 56336 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTML5Lexer.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 3 2010-05-18 01:54:02 PDT
Created attachment 56337 [details] Patch
WebKit Review Bot
Comment 4 2010-05-18 01:56:26 PDT
Attachment 56337 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTML5Lexer.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 5 2010-05-18 02:05:04 PDT
Comment on attachment 56337 [details] Patch This won't actually work... But it's better than what we have. :) This will end up "returning" the last token processed from a SegementedString, instead of returning the first.
Note You need to log in before you can comment on or make changes to this bug.