Bug 39274 - Add an HTML5Token
Summary: Add an HTML5Token
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency tree / graph
 
Reported: 2010-05-18 01:49 PDT by Adam Barth
Modified: 2010-05-19 09:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.01 KB, patch)
2010-05-18 01:51 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (9.02 KB, patch)
2010-05-18 01:54 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-18 01:49:03 PDT 
Add an HTML5Token
Comment 1 Adam Barth 2010-05-18 01:51:32 PDT 
Created attachment 56336 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-18 01:53:45 PDT 
Attachment 56336 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTML5Lexer.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2010-05-18 01:54:02 PDT 
Created attachment 56337 [details]
Patch
Comment 4 WebKit Review Bot 2010-05-18 01:56:26 PDT 
Attachment 56337 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTML5Lexer.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Seidel (no email) 2010-05-18 02:05:04 PDT 
Comment on attachment 56337 [details]
Patch

This won't actually work...  But it's better than what we have. :)

This will end up "returning" the last token processed from a SegementedString, instead of returning the first.