Bug 38980

Summary: [Qt] Slave losts cause build break on bots.
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: eric, hausmann, ossy
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 38969    
Attachments:
Description Flags
proposed fix
none
proposed fix
eric: review-
proposed fix
none
Patch none

Csaba Osztrogonác
Reported 2010-05-12 02:40:36 PDT
When slave lost (internet connection lost) occured, the buildbot slave executes a kill -9 command to kill the build process. It cause some 0 byte sized files is build directory which won't be recompiled at next build, and we will get link error. Only removing 0 byte sized files solve the problem.
Attachments
proposed fix (1.19 KB, patch)
2010-05-12 02:43 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed fix (1.29 KB, patch)
2010-05-12 03:46 PDT, Csaba Osztrogonác 		eric: review-
DetailsFormatted DiffDiff
proposed fix (1.37 KB, patch)
2010-05-12 11:03 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2012-06-12 04:21 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-05-12 02:43:06 PDT
Created attachment 55821 [details] proposed fix
Csaba Osztrogonác
Comment 2 2010-05-12 03:46:18 PDT
Created attachment 55827 [details] proposed fix Xan noticed me that GTK build has 0 byte sized .dirstamp files in builddir shouldn't be deleted before all build. I modified my patch not to remove any hidden files. I hope other ports don't have necessary 0 byte sized files. :)
Eric Seidel (no email)
Comment 3 2010-05-12 08:49:22 PDT
Comment on attachment 55827 [details] proposed fix It should print out status to the user and explain what it's doing. I think this code should only run on Gtk for now.
Eric Seidel (no email)
Comment 4 2010-05-12 08:49:34 PDT
Only run on Qt, rather.
Csaba Osztrogonác
Comment 5 2010-05-12 11:03:10 PDT
Created attachment 55871 [details] proposed fix I think this cleanup before build might be useful for other ports too, but I put it into an isQt() block. In the future anybody can enable it for other ports. And now the script dumps which files was removed to stdout.
Csaba Osztrogonác
Comment 6 2010-05-12 13:33:53 PDT
Landed manually: http://trac.webkit.org/changeset/59261
Eric Seidel (no email)
Comment 7 2010-05-12 13:36:26 PDT
Comment on attachment 55871 [details] proposed fix I'm not sure thsi really belongs as part of webkit-build, but rather in teh Qt builder config. But this is OK for now.
Csaba Osztrogonác
Comment 8 2012-06-12 04:20:24 PDT
Reopen to attach a minor fix.
Csaba Osztrogonác
Comment 9 2012-06-12 04:21:37 PDT
Created attachment 147051 [details] Patch minor fix
Csaba Osztrogonác
Comment 10 2012-06-12 04:54:51 PDT
Comment on attachment 147051 [details] Patch Landed in http://trac.webkit.org/changeset/120060
Note You need to log in before you can comment on or make changes to this bug.