Bug 38969

Summary:

Qt build failures cause SheriffBot false positives

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

38980

Bug Blocks:

Attachments:

Description	Flags
Patch	eric: review+
Add Qt bots back to the core builders	abarth: review+

Adam Barth

Reported 2010-05-11 21:37:08 PDT

Qt build failures cause SheriffBot false positives

Attachments
Patch (2.67 KB, patch) 2010-05-11 21:40 PDT, Adam Barth	eric: review+	Details Formatted Diff Diff
Add Qt bots back to the core builders (2.31 KB, patch) 2010-05-12 14:33 PDT, Csaba Osztrogonác	abarth: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-05-11 21:39:08 PDT

Specifically some sort of 0-sized file after slave lost. This has been a problem for weeks.

Adam Barth

Comment 2 2010-05-11 21:40:38 PDT

Created attachment 55803 [details] Patch

Adam Barth

Comment 3 2010-05-11 21:41:34 PDT

From the ChangeLog: The Qt buildbot randomly fails to compile occasionally because its network connection causes SVn to leave zero-byte files around. These compile failures confuse SheriffBot into thinking someone's patch caused a build break. In this patch, I've temporarily removed Qt from the list of core builders. Ossy is working on a script to clean up the zero byte files. Once that goes in, we can add Qt back to the core builders. Hopefully this will be temporary.

Eric Seidel (no email)

Comment 4 2010-05-11 21:42:57 PDT

Comment on attachment 55803 [details] Patch OK.

Adam Barth

Comment 5 2010-05-11 21:44:15 PDT

Committed r59207: <http://trac.webkit.org/changeset/59207>

Csaba Osztrogonác

Comment 6 2010-05-12 14:31:52 PDT

0 byte sized files problem fixed: http://trac.webkit.org/changeset/59261

Csaba Osztrogonác

Comment 7 2010-05-12 14:33:57 PDT

Created attachment 55904 [details] Add Qt bots back to the core builders