Bug 38942
| Summary: | Improve check-webkit-style to detect that FeatureDefines.xcconfig is not in sync | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jian Li <jianli> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | eric, gbalogh.u-szeged, jianli, llango.u-szeged, lvidacs.u-szeged, mrowe, ossy |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Jian Li
All instances of FeatureDefines.xcconfig need to sync up. Otherwise, the build could be broken. See comments from WebCore/Configuration/FeatureDefines.xcconfig.
// The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore,
// WebCore and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in build-webkit
// should match the values below, but they do not need to be in the same order.
To avoid this, we could write a script to compare those FeatureDefines.xcconfig and run it from build-webkit. This should make us detect the problem earlier.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
See also: http://trac.webkit.org/changeset/59181
Csaba Osztrogonác
To ensure FeatureDefines.xcconfig files are in sync, the best place
is chack-webkit-style. Now they are in sync. If somebody tried to
add a change accidentally break it, check-webkit-style or style bot
would notice it.
Csaba Osztrogonác
*** This bug has been marked as a duplicate of bug 125748 ***