| Summary: | Crash closing window containing Flash plug-in | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> | ||||
| Component: | Plug-ins | Assignee: | Jon Honeycutt <jhoneycutt> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, webkit.review.bot, xan.lopez | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| URL: | http://www.metacafe.com/watch/816714/kruger_park_battle_lions_vs_crocodile_vs_warter_buf | ||||||
| Bug Depends on: | 38881 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Jon Honeycutt
2010-05-08 00:03:25 PDT
Created attachment 55464 [details]
patch
Attachment 55464 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp:109: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp:111: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 55464 [details]
patch
Looks sane.
Looks like this needs to be skipped on Gtk: http://build.webkit.org/results/Qt%20Linux%20Release/r59100%20(11532)/plugins/geturlnotify-during-document-teardown-pretty-diff.html http://trac.webkit.org/changeset/59100 might have broken GTK Linux 32-bit Release and Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/59099 http://trac.webkit.org/changeset/59100 |