Bug 38609

Summary: Expose FileReader interface
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore JavaScriptAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, kinuko
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 38615    
Attachments:
Description Flags
Proposed Patch
jianli: commit-queue-
Proposed Patch
jianli: commit-queue-
Proposed Patch
jianli: commit-queue-
Proposed Patch
dimich: review-, jianli: commit-queue-
Proposed Patch dimich: review+, jianli: commit-queue-

Jian Li
Reported 2010-05-05 14:43:07 PDT
Need to add FileReader.idl to expose FileReader interface as defined in File API spec (http://www.w3.org/TR/file-upload/#dfn-filereader).
Attachments
Proposed Patch (41.95 KB, patch)
2010-05-05 17:32 PDT, Jian Li 		jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (42.63 KB, patch)
2010-05-05 17:42 PDT, Jian Li 		jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (34.63 KB, patch)
2010-05-06 18:15 PDT, Jian Li 		jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (34.37 KB, patch)
2010-05-06 18:17 PDT, Jian Li 		dimich: review-
jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (33.03 KB, patch)
2010-05-07 11:31 PDT, Jian Li 		dimich: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-05-05 17:32:40 PDT
Created attachment 55178 [details] Proposed Patch This patch contains changes to JSC bindings only.
Jian Li
Comment 2 2010-05-05 17:42:32 PDT
Created attachment 55181 [details] Proposed Patch Updated the patch with "--binary" being used for the binary files.
Jian Li
Comment 3 2010-05-06 13:59:37 PDT
Comment on attachment 55181 [details] Proposed Patch Will resubmit after the code generator change (38687) is done.
Jian Li
Comment 4 2010-05-06 18:15:05 PDT
Created attachment 55329 [details] Proposed Patch Updated the patch since we do not need any custom binding codes now.
Jian Li
Comment 5 2010-05-06 18:17:07 PDT
Created attachment 55331 [details] Proposed Patch Forgot to update WebCore/ChangeLog to remove unneeded files.
Dmitry Titov
Comment 6 2010-05-06 19:20:39 PDT
Comment on attachment 55331 [details] Proposed Patch Looks great. One thing - could you please organize the output of the test in such a way as to avoid the file-reader-expected.txt to be a binary file? If it is binary, it will be harder to see in various tools what will change in subsequent changes. Also, it'd be cool if the patch could pass EWS, less potential troubles this way. r- to consider the expected file format.
Jian Li
Comment 7 2010-05-07 11:31:30 PDT
Created attachment 55398 [details] Proposed Patch
Dmitry Titov
Comment 8 2010-05-07 11:39:28 PDT
Comment on attachment 55398 [details] Proposed Patch r=me
Jian Li
Comment 9 2010-05-11 16:12:57 PDT
Committed as http://trac.webkit.org/changeset/59162.
Note You need to log in before you can comment on or make changes to this bug.