Bug 38301

Summary: Change chromium WebViewClient::createView to include WindowFeatures
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 38332    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Rafael Weinstein
Reported 2010-04-28 18:30:48 PDT
This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=38013 which now additionally passes the WindowFeatures to the WebViewClient::createView method.
Attachments
Patch (3.11 KB, patch)
2010-04-28 18:45 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2010-04-29 19:18 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2010-04-28 18:45:33 PDT
Created attachment 54658 [details] Patch
WebKit Commit Bot
Comment 2 2010-04-29 03:55:30 PDT
Comment on attachment 54658 [details] Patch Clearing flags on attachment: 54658 Committed r58498: <http://trac.webkit.org/changeset/58498>
WebKit Commit Bot
Comment 3 2010-04-29 03:55:37 PDT
All reviewed patches have been landed. Closing bug.
Dimitri Glazkov (Google)
Comment 4 2010-04-29 09:14:53 PDT
This broke about a bunch of tests on the canaries. Has the method been hooked up properly downstream?
Rafael Weinstein
Comment 5 2010-04-29 19:18:45 PDT
Created attachment 54773 [details] Patch
Rafael Weinstein
Comment 6 2010-04-29 19:21:17 PDT
The first attempt at landing this patch broke the chromium canary bot because I missed an implementor of WebClientView (TestWebClientDelegate in test_shell). This has been addressed in http://src.chromium.org/viewvc/chrome?view=rev&revision=46024.
WebKit Commit Bot
Comment 7 2010-05-02 00:23:25 PDT
Comment on attachment 54773 [details] Patch Clearing flags on attachment: 54773 Committed r58643: <http://trac.webkit.org/changeset/58643>
WebKit Commit Bot
Comment 8 2010-05-02 00:23:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.