Bug 38122 – check-webkit-style: Rename the processors/ directory to checkers/

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Chris Jerdonek]

This is to address a FIXME introduced in--

https://bugs.webkit.org/show_bug.cgi?id=37066

[Chris Jerdonek]

Created attachment 54286 [details]
Proposed patch

The only changes that are not the directory move are updating the import statements in checker.py and checker_unittest.py and changing one word in a comment.

[WebKit Review Bot]

Attachment 54286 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 52, in <module>
    import webkitpy.style.checker as checker
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 37, in <module>
    from checkers.common import categories as CommonCategories
ImportError: No module named checkers.common


If any of these errors are false positives, please file a bug against check-webkit-style.

[Shinichiro Hamaji]

Comment on attachment 54286 [details]
Proposed patch

Looks like these files were just remoevd :)

[Chris Jerdonek]

(In reply to comment #3)
> (From update of attachment 54286 [details])
> Looks like these files were just remoevd :)

This is a limitation of svn-create-patch.  See for example--

https://bugs.webkit.org/show_bug.cgi?id=35196#c4

Sorry, I thought you knew about this.  Otherwise I would have mentioned that in the comment.  (That's why I put cq-.)

[Shinichiro Hamaji]

Comment on attachment 54286 [details]
Proposed patch

Ah, I didn't know that. Thanks for the info. Looks good, assuming you'll add these files.

[Chris Jerdonek]

Committed: http://trac.webkit.org/changeset/58263