Bug 37740

Summary: Web Inspector: move JavaScriptCallFrame to bindings
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, eric, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 37663    
Attachments:
Description Flags
patch
pfeldman: review-
patch none

Yury Semikhatsky
Reported 2010-04-16 17:51:16 PDT
We need to move WebCore/inspector/JavaScriptCallFrame.{h,cpp} to the bindings layer to allow VM-specific implementations.
Attachments
patch (24.67 KB, patch)
2010-04-16 17:55 PDT, Yury Semikhatsky 		pfeldman: review-
DetailsFormatted DiffDiff
patch (22.56 KB, patch)
2010-04-17 11:25 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-04-16 17:55:06 PDT
Created attachment 53586 [details] patch
WebKit Review Bot
Comment 2 2010-04-16 17:59:03 PDT
Attachment 53586 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebCore/bindings/js/JavaScriptCallFrame.h:34: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/js/JavaScriptCallFrame.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] WARNING: Skipping non-existent file: WebCore/inspector/JavaScriptCallFrame.cpp WARNING: Skipping non-existent file: WebCore/inspector/JavaScriptCallFrame.h WebCore/bindings/js/JavaScriptCallFrame.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] WebCore/bindings/js/JavaScriptCallFrame.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2010-04-16 18:01:04 PDT
Attachment 53586 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1658446
Pavel Feldman
Comment 4 2010-04-16 18:01:20 PDT
Comment on attachment 53586 [details] patch 1) Remove tab characters? 2) xproj file seems to be wrong r- for project file.
Yury Semikhatsky
Comment 5 2010-04-17 11:25:07 PDT
Created attachment 53600 [details] patch Addressed the comments.
WebKit Commit Bot
Comment 6 2010-04-17 11:42:17 PDT
Comment on attachment 53600 [details] patch Clearing flags on attachment: 53600 Committed r57784: <http://trac.webkit.org/changeset/57784>
WebKit Commit Bot
Comment 7 2010-04-17 11:42:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.