Bug 37553
| Summary: | commit-queue only needs to retry if tests fail (not if apply or build fails) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, mihaip |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
commit-queue does not need to try again when a patch fails to apply
Fetching: https://bugs.webkit.org/attachment.cgi?id=53225&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=37493&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 53225 from bug 37493.
Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Maciej Stachowiak', '--force']" exit_code: 1
Cleaning working directory
Building WebKit
Running Python unit tests
Running Perl unit tests
Running JavaScriptCore tests
Running run-webkit-tests
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
The commit-queue also doesn't need to try again when the commit fails due to checkout out of date. Or at least it doesn't need to try to confirm that trunk builds.
Eric Seidel (no email)
*** Bug 44928 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
This caused the commit-queue to hang with a rollout today. see Bug 44928