Summary: | Tighten SheriffBot's flaky test detector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dbates, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 36911 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Adam Barth
2010-04-03 14:01:40 PDT
Created attachment 52500 [details]
Patch
Need to add "Tests that caused the DumpRenderTree tool to crash:" as a results key. This patch really wants bug 36911 to be landed first. :) Created attachment 52518 [details]
Patch
Committed r57065: <http://trac.webkit.org/changeset/57065> Sorry for landing this change unreviewed. I pulled over the relevant code from Bug 36911. I'm leaving this bug open so Eric can give me an after-the-fact review when he wakes up. Comment on attachment 52518 [details] Patch This really wanted bug 36911, since this is basicaly a re-write of that logic. :( test_no_results is wrong. Otherwise looks OK. What is the status with this bug? Can we close it? |