Bug 36936

Summary: Factor DocumentSwitcher out of FrameLoader
Product: WebKit Reporter: Adam Barth <abarth>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: cmarcelo, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 29947    
Attachments:
Description Flags
Work in progress (does not compile)
none
More work in progress none

Adam Barth
Reported 2010-04-01 00:10:15 PDT
FrameLoader does many things. One of its core responsibilities is to switch around m_documentLoader, m_provisionalDocumentLoader, and m_policyDocumentLoader. Unlike my previous patches (which moved "front-end" code out of FrameLoader), this patch will move "back-end" code out of FrameLoader. DocumentSwitcher is intended to encapsulate write access to the document loaders as well as m_state, as distinct from the various load* methods of FrameLoader (which are closer to the front of the loading pipeline).
Attachments
Work in progress (does not compile) (20.38 KB, patch)
2010-04-01 00:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
More work in progress (33.36 KB, patch)
2010-04-05 16:33 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-01 00:11:13 PDT
Created attachment 52266 [details] Work in progress (does not compile)
Sam Weinig
Comment 2 2010-04-01 17:50:40 PDT
I love it! But can you move it to a new file.
Adam Barth
Comment 3 2010-04-01 18:10:47 PDT
Sure. :)
Adam Barth
Comment 4 2010-04-05 16:33:55 PDT
Created attachment 52588 [details] More work in progress
Adam Barth
Comment 5 2010-04-05 16:34:25 PDT
I realized that m_loadType should move back to FrameLoader. Turns out FrameLoader is very complicated.
Note You need to log in before you can comment on or make changes to this bug.