Bug 36936

Summary:

Factor DocumentSwitcher out of FrameLoader

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

cmarcelo, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

29947

Attachments:

Description	Flags
Work in progress (does not compile)	none
More work in progress	none

Description Adam Barth 2010-04-01 00:10:15 PDT

FrameLoader does many things.  One of its core responsibilities is to switch around m_documentLoader, m_provisionalDocumentLoader, and m_policyDocumentLoader.  Unlike my previous patches (which moved "front-end" code out of FrameLoader), this patch will move "back-end" code out of FrameLoader.

DocumentSwitcher is intended to encapsulate write access to the document loaders as well as m_state, as distinct from the various load* methods of FrameLoader (which are closer to the front of the loading pipeline).

Comment 1 Adam Barth 2010-04-01 00:11:13 PDT

Created attachment 52266 [details]
Work in progress (does not compile)

Comment 2 Sam Weinig 2010-04-01 17:50:40 PDT

I love it! But can you move it to a new file.

Comment 3 Adam Barth 2010-04-01 18:10:47 PDT

Sure.  :)

Comment 4 Adam Barth 2010-04-05 16:33:55 PDT

Created attachment 52588 [details]
More work in progress

Comment 5 Adam Barth 2010-04-05 16:34:25 PDT

I realized that m_loadType should move back to FrameLoader.  Turns out FrameLoader is very complicated.