Bug 36368

Summary:

[Qt] Maemo5 theme - customized popup for <select multiple> elements

Product:

WebKit

Reporter:

Luiz Agostini <luiz>

Component:

Platform

Assignee:

Luiz Agostini <luiz>

Status:

CLOSED FIXED

Severity:

Normal

CC:

eric, hausmann, kenneth

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Bug Depends on:

36186, 36769, 36789

Bug Blocks:

36372

Attachments:

Description	Flags
patch 1	none
patch 2	commit-queue: commit-queue-

Luiz Agostini

Reported 2010-03-19 08:09:52 PDT

Maemo5 should use multiselect popups. For it to work it is needed to check if QComboBox can be used for <select multiple> and if not a new popup class must be created. QtFallbackWebPopup must be adjusted anyway.

Attachments
patch 1 (3.90 KB, patch) 2010-03-29 16:44 PDT, Luiz Agostini	no flags	Details Formatted Diff Diff
patch 2 (3.87 KB, patch) 2010-03-31 11:52 PDT, Luiz Agostini	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tor Arne Vestbø

Comment 1 2010-03-22 06:37:00 PDT

Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs

Luiz Agostini

Comment 2 2010-03-29 16:44:06 PDT

Created attachment 51982 [details] patch 1

Luiz Agostini

Comment 3 2010-03-31 11:52:04 PDT

Created attachment 52192 [details] patch 2

Kenneth Rohde Christiansen

Comment 4 2010-04-01 20:20:15 PDT

Comment on attachment 52192 [details] patch 2 r=me, but in the future please write everything you are doing in the ChangeLog, like that you removed Maemo related code in the fallback and why that is right. I am still reviewing positively as I discussed the patch with you in person.

WebKit Commit Bot

Comment 5 2010-04-02 00:39:39 PDT

Comment on attachment 52192 [details] patch 2 Clearing flags on attachment: 52192 Committed r56980: <http://trac.webkit.org/changeset/56980>

WebKit Commit Bot

Comment 6 2010-04-02 00:39:45 PDT

Comment on attachment 52192 [details] patch 2 Rejecting patch 52192 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--build-style=both', '--quiet', '52192', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 546, in __getattr__ self.forms() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 559, in forms self._forms_factory.forms()) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 228, in forms raise ParseError(exc) webkitpy.thirdparty.autoinstalled.mechanize._html.ParseError

Eric Seidel (no email)

Comment 7 2010-04-02 01:21:36 PDT

This was bug 33659. Sorry about that.

Luiz Agostini

Comment 8 2010-04-05 07:15:07 PDT

patch is landed.

Luiz Agostini

Comment 9 2010-04-05 07:32:24 PDT

landed in r56980

Simon Hausmann

Comment 10 2010-04-06 03:09:27 PDT

Revision r56980 cherry-picked into qtwebkit-2.0 with commit 9696a3d63eef6d6aca9e5eb7724e235b57c5a9f7

Note You need to log in before you can comment on or make changes to this bug.