Bug 36216

Summary:

[Qt] GraphicsLayer: support fill-modes

Product:

WebKit

Reporter:

Noam Rosenthal <noam>

Component:

Layout and Rendering

Assignee:

Noam Rosenthal <noam>

Status:

CLOSED FIXED

Severity:

Normal

CC:

abarth, benjamin, commit-queue, eric, hausmann, kenneth, koivisto, ossy, tonikitoo, webkit.review.bot

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

37746

Bug Blocks:

36191

Attachments:

Description	Flags
implemet fill modes in GraphicsLayerQt	none
removed unnecessary function	none
re-submitting the patch, this time with a couple of more null-checks I overlooked in the first patch. All the regressed tests worked for me after this patch.	kenneth: review-, commit-queue: commit-queue-
changelog was mistakenly omitted from previous patch	none

Noam Rosenthal

Reported 2010-03-17 06:00:38 PDT

fill-modes are a new webkit CSS concept that allows for compound sequential animations. This needs to be special-cased in GraphicsLayer. test: LayoutTests/animations/fill-mode-transform.html

Attachments
implemet fill modes in GraphicsLayerQt (6.52 KB, patch) 2010-04-16 16:23 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
removed unnecessary function (6.20 KB, patch) 2010-04-16 16:37 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
re-submitting the patch, this time with a couple of more null-checks I overlooked in the first patch. All the regressed tests worked for me after this patch. (3.92 KB, patch) 2010-04-19 00:07 PDT, Noam Rosenthal	kenneth: review- commit-queue: commit-queue-	Details Formatted Diff Diff
changelog was mistakenly omitted from previous patch (6.28 KB, patch) 2010-04-19 11:36 PDT, Noam Rosenthal	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Noam Rosenthal

Comment 1 2010-04-16 16:23:14 PDT

Created attachment 53576 [details] implemet fill modes in GraphicsLayerQt

Antti Koivisto

Comment 2 2010-04-16 16:36:00 PDT

r=me, please remove the unused fillBackwards function

Noam Rosenthal

Comment 3 2010-04-16 16:37:11 PDT

Created attachment 53580 [details] removed unnecessary function

WebKit Commit Bot

Comment 4 2010-04-16 19:05:00 PDT

Comment on attachment 53580 [details] removed unnecessary function Clearing flags on attachment: 53580 Committed r57770: <http://trac.webkit.org/changeset/57770>

WebKit Commit Bot

Comment 5 2010-04-16 19:05:05 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 6 2010-04-16 19:23:32 PDT

http://trac.webkit.org/changeset/57770 might have broken Qt Linux Release

Csaba Osztrogonác

Comment 7 2010-04-16 23:42:41 PDT

(In reply to comment #6) > http://trac.webkit.org/changeset/57770 might have broken Qt Linux Release Rollout committed in http://trac.webkit.org/changeset/57776

Csaba Osztrogonác

Comment 8 2010-04-16 23:44:59 PDT

rollout bug: https://bugs.webkit.org/show_bug.cgi?id=37746 crashed caused by the original bug: http://build.webkit.org/results/Qt%20Linux%20Release/r57770%20%2810253%29/results.html First I tried to do a clean build, but it didn't resolve the crashes, so I had to rollout the patch.

Eric Seidel (no email)

Comment 9 2010-04-18 16:28:28 PDT

Comment on attachment 53576 [details] implemet fill modes in GraphicsLayerQt Cleared Antti Koivisto's review+ from obsolete attachment 53576 [details] so that this bug does not appear in http://webkit.org/pending-commit.

Noam Rosenthal

Comment 10 2010-04-19 00:07:37 PDT

Created attachment 53655 [details] re-submitting the patch, this time with a couple of more null-checks I overlooked in the first patch. All the regressed tests worked for me after this patch.

WebKit Commit Bot

Comment 11 2010-04-19 09:32:01 PDT

Comment on attachment 53655 [details] re-submitting the patch, this time with a couple of more null-checks I overlooked in the first patch. All the regressed tests worked for me after this patch. Rejecting patch 53655 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html

Kenneth Rohde Christiansen

Comment 12 2010-04-19 10:35:11 PDT

You are right, how could I have missed that :-(. I will r- it for that reason.

Csaba Osztrogonác

Comment 13 2010-04-19 11:04:30 PDT

(In reply to comment #10) > Created an attachment (id=53655) [details] > re-submitting the patch, this time with a couple of more null-checks I > overlooked in the first patch. All the regressed tests worked for me after this > patch. I tested it on bot, it will work without crashes.

Noam Rosenthal

Comment 14 2010-04-19 11:36:24 PDT

Created attachment 53695 [details] changelog was mistakenly omitted from previous patch

WebKit Commit Bot

Comment 15 2010-04-20 01:28:11 PDT

Comment on attachment 53695 [details] changelog was mistakenly omitted from previous patch Clearing flags on attachment: 53695 Committed r57878: <http://trac.webkit.org/changeset/57878>

WebKit Commit Bot

Comment 16 2010-04-20 01:28:18 PDT

All reviewed patches have been landed. Closing bug.

Simon Hausmann

Comment 17 2010-04-20 13:05:19 PDT

Revision r57878 cherry-picked into qtwebkit-2.0 with commit 6b307dc15ad5180ba95bb97df76f0cfcc2e8bf22

Note You need to log in before you can comment on or make changes to this bug.