Bug 36178

Summary: Multiselect Popup - PopupMenuClient extension
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: WebCore Misc.Assignee: Luiz Agostini <luiz>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, kenneth, koivisto, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 36177    
Bug Blocks: 36186    
Attachments:
Description Flags
patch 1
none
patch 2
none
patch 3
none
patch 4 none

Luiz Agostini
Reported 2010-03-16 11:54:00 PDT
PopupMenuClient class is the interface used by combobox popup implementations. It needs to be extended to handle <select multiple> needs.
Attachments
patch 1 (5.82 KB, patch)
2010-03-16 14:01 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 2 (5.91 KB, patch)
2010-03-18 10:39 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 3 (5.77 KB, patch)
2010-03-18 11:02 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 4 (5.96 KB, patch)
2010-03-18 15:42 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-03-16 14:01:34 PDT
Created attachment 50833 [details] patch 1
Antonio Gomes
Comment 2 2010-03-16 14:15:07 PDT
+ Document* doc = static_cast<Element*>(node())->document(); no need to cast here, luiz: node()->document() +if (!doc || doc != doc->frame()->document()) that looks odd :)
Kenneth Rohde Christiansen
Comment 3 2010-03-18 08:15:15 PDT
Remove [Qt] from title as this patch doesn't even touch Qt code. Add Qt as keyword so that it shows up in our filters
Luiz Agostini
Comment 4 2010-03-18 10:39:43 PDT
Created attachment 51046 [details] patch 2
Luiz Agostini
Comment 5 2010-03-18 11:02:57 PDT
Created attachment 51055 [details] patch 3
Dave Hyatt
Comment 6 2010-03-18 12:27:43 PDT
Comment on attachment 51055 [details] patch 3 Let's call it ListPopupMenuClient instead of just ListPopupClient. I think you should wrap all the code in this patch inside #if ENABLE(NO_LISTBOX_RENDERING). That will help people understand that this is unique to that feature. Everything else looks fine.
Luiz Agostini
Comment 7 2010-03-18 15:42:30 PDT
Created attachment 51105 [details] patch 4
Antti Koivisto
Comment 8 2010-03-19 09:10:04 PDT
Comment on attachment 51105 [details] patch 4 Looks good, r=me
WebKit Commit Bot
Comment 9 2010-03-19 17:08:39 PDT
Comment on attachment 51105 [details] patch 4 Clearing flags on attachment: 51105 Committed r56285: <http://trac.webkit.org/changeset/56285>
WebKit Commit Bot
Comment 10 2010-03-19 17:08:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.