Bug 36178

Summary: Multiselect Popup - PopupMenuClient extension
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: WebCore Misc.Assignee: Luiz Agostini <luiz>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, kenneth, koivisto, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 36177    
Bug Blocks: 36186    
Description Flags
patch 1
patch 2
patch 3
patch 4 none

Description Luiz Agostini 2010-03-16 11:54:00 PDT
PopupMenuClient class is the interface used by combobox popup implementations. It needs to be extended to handle <select multiple> needs.
Comment 1 Luiz Agostini 2010-03-16 14:01:34 PDT
Created attachment 50833 [details]
patch 1
Comment 2 Antonio Gomes 2010-03-16 14:15:07 PDT
+ Document* doc = static_cast<Element*>(node())->document();

no need to cast here, luiz: node()->document()

+if (!doc || doc != doc->frame()->document())

that looks odd :)
Comment 3 Kenneth Rohde Christiansen 2010-03-18 08:15:15 PDT
Remove [Qt] from title as this patch doesn't even touch Qt code. Add Qt as keyword so that it shows up in our filters
Comment 4 Luiz Agostini 2010-03-18 10:39:43 PDT
Created attachment 51046 [details]
patch 2
Comment 5 Luiz Agostini 2010-03-18 11:02:57 PDT
Created attachment 51055 [details]
patch 3
Comment 6 Dave Hyatt 2010-03-18 12:27:43 PDT
Comment on attachment 51055 [details]
patch 3

Let's call it ListPopupMenuClient instead of just ListPopupClient.

I think you should wrap all the code in this patch inside #if ENABLE(NO_LISTBOX_RENDERING).  That will help people understand that this is unique to that feature.

Everything else looks fine.
Comment 7 Luiz Agostini 2010-03-18 15:42:30 PDT
Created attachment 51105 [details]
patch 4
Comment 8 Antti Koivisto 2010-03-19 09:10:04 PDT
Comment on attachment 51105 [details]
patch 4

Looks good, r=me
Comment 9 WebKit Commit Bot 2010-03-19 17:08:39 PDT
Comment on attachment 51105 [details]
patch 4

Clearing flags on attachment: 51105

Committed r56285: <http://trac.webkit.org/changeset/56285>
Comment 10 WebKit Commit Bot 2010-03-19 17:08:44 PDT
All reviewed patches have been landed.  Closing bug.