Bug 35968

Summary: [Qt] QScriptValuePrivate::States has naming issues
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Severity: Normal CC: commit-queue
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31863    
Description Flags
Fix v1 none

Description Jędrzej Nowacki 2010-03-10 05:37:53 PST
- The enum States has invalid name, according to Qt coding style it should be "State" as enum's elements are not flags that could be or'ed or and'ed.
- JSNative should be renamed to JSPrimitive as "primitive value" is a corresponding name in ECMA Script standard ("A primitive value is a member of one of the following built-in types: Undefined, Null, Boolean, Number, and String").
Comment 1 Jędrzej Nowacki 2010-03-10 06:08:36 PST
Created attachment 50397 [details]
Fix v1
Comment 2 WebKit Commit Bot 2010-03-11 21:41:48 PST
Comment on attachment 50397 [details]
Fix v1

Clearing flags on attachment: 50397

Committed r55887: <http://trac.webkit.org/changeset/55887>
Comment 3 WebKit Commit Bot 2010-03-11 21:41:52 PST
All reviewed patches have been landed.  Closing bug.