Bug 35918

Summary: [EFL] Add EditorClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport.
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: barbieri, bunhere, commit-queue, gustavo, gyuyoung.kim, hyuki.a.kim, hyuki.kim, joone.hur, rakuco, tonikitoo, zecke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Add EditorClientEfl to WK/efl/WebCoreSupport. none

Leandro Pereira
Reported 2010-03-09 06:26:58 PST
+++ This bug was initially created as a clone of Bug #35059 +++ Attached patch adds EFL's implementation of EditorClientEfl to WebKit/efl/WebCoreSupport.
Attachments
Add EditorClientEfl to WK/efl/WebCoreSupport. (20.55 KB, patch)
2010-03-09 06:27 PST, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leandro Pereira
Comment 1 2010-03-09 06:27:38 PST
Created attachment 50301 [details] Add EditorClientEfl to WK/efl/WebCoreSupport.
Holger Freyther
Comment 2 2010-03-14 19:00:03 PDT
It would be nice if you could share this table with the Gtk+ port somehow. Or at least create a follow up patch patching both Gtk and Efl to mention the others copy of the table and that they need to be kept in sync.... It would be preferable to not have that duplication.
Leandro Pereira
Comment 3 2010-03-31 08:02:13 PDT
(In reply to comment #2) > It would be nice if you could share this table with the Gtk+ port somehow. Or > at least create a follow up patch patching both Gtk and Efl to mention the > others copy of the table and that they need to be kept in sync.... It would be > preferable to not have that duplication. There's a copy of this table in other ports, too (at least with this same name): Wx and Chromium. Do you have any ideas on how this table could be shared amongst all ports that use it, besides having a comment to keep them in sync?
Kenneth Rohde Christiansen
Comment 4 2010-04-15 12:04:07 PDT
Comment on attachment 50301 [details] Add EditorClientEfl to WK/efl/WebCoreSupport. LGTM
WebKit Commit Bot
Comment 5 2010-04-15 13:18:09 PDT
Comment on attachment 50301 [details] Add EditorClientEfl to WK/efl/WebCoreSupport. Clearing flags on attachment: 50301 Committed r57665: <http://trac.webkit.org/changeset/57665>
WebKit Commit Bot
Comment 6 2010-04-15 13:18:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.