Bug 35915

Summary:

[EFL] Add FrameLoaderClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport

Product:

WebKit

Reporter:

Leandro Pereira <leandro>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

barbieri, bunhere, commit-queue, gustavo, gyuyoung.kim, hyuki.a.kim, hyuki.kim, joone.hur, rakuco, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.	kenneth: review+, kenneth: commit-queue-
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.	none

Leandro Pereira

Reported 2010-03-09 06:19:07 PST

+++ This bug was initially created as a clone of Bug #35059 +++ Attached patch adds EFL's implementation of FrameLoaderClient to WebKit/efl/WebCoreSupport.

Attachments
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport. (34.26 KB, patch) 2010-03-09 06:21 PST, Leandro Pereira	kenneth: review+ kenneth: commit-queue-	Details Formatted Diff Diff
Add FrameLoaderClientEfl to WK/efl/WebCoreSupport. (34.21 KB, patch) 2010-04-15 15:33 PDT, Leandro Pereira	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Leandro Pereira

Comment 1 2010-03-09 06:21:05 PST

Created attachment 50298 [details] Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.

Kenneth Rohde Christiansen

Comment 2 2010-04-15 12:02:35 PDT

Comment on attachment 50298 [details] Add FrameLoaderClientEfl to WK/efl/WebCoreSupport. On the mobile you probably want to say Mobile Safari and not Safari in the UA. > +PassRefPtr<Frame> FrameLoaderClientEfl::createFrame(const KURL& url, const String& name, HTMLFrameOwnerElement* ownerElement, > + const String& referrer, bool allowsScrolling, int marginWidth, int marginHeight) Please keep these method definitions on one line. Apart from that, it looks fine as an initial commit.

Leandro Pereira

Comment 3 2010-04-15 15:33:58 PDT

Created attachment 53483 [details] Add FrameLoaderClientEfl to WK/efl/WebCoreSupport. Kenneth already r+'ed this patch. I've fixed the createFrame definition. Regarding the user agent, our API supports changing the user agent, so this won't be a huge issue if someone develops a mobile browser with the EFL port. This will be fixed, of course.

WebKit Commit Bot

Comment 4 2010-04-16 00:03:29 PDT

Comment on attachment 53483 [details] Add FrameLoaderClientEfl to WK/efl/WebCoreSupport. Clearing flags on attachment: 53483 Committed r57716: <http://trac.webkit.org/changeset/57716>

WebKit Commit Bot

Comment 5 2010-04-16 00:03:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.