Bug 35521

Summary: [Android] The platform touch events on Android are missing support for key modifiers.
Product: WebKit Reporter: Ben Murdoch <benm>
Component: WebCore Misc.Assignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 32485    
Attachments:
Description Flags
Proposed Patch.
none
Patch sans-tab.
none
Proposed Patch. jorlow: review+

Description Ben Murdoch 2010-03-01 04:13:40 PST
This bug is to track upstreaming of support for key modifiers and event time in Touch Events on Android.
Comment 1 Ben Murdoch 2010-03-08 04:15:59 PST
Created attachment 50204 [details]
Proposed Patch.

Adds support for key modifiers in Android touch events. Also adds a platformEventTime member to touch events to reflect the time that the event was started on the platform side rather than the WebCore side. For example, on Android this is set to the Java side touch event time. Due to the asynchronous nature of Android's touch event handling, this platform time may be significantly different to the time that the event is constructed inside WebCore.
Comment 2 Ben Murdoch 2010-03-08 04:18:37 PST
Created attachment 50205 [details]
Patch sans-tab.

Removed a couple of tabs from the Changelog.
Comment 3 Ben Murdoch 2010-03-10 07:29:55 PST
Created attachment 50402 [details]
Proposed Patch.
Comment 4 Ben Murdoch 2010-03-11 03:56:58 PST
Please note that contrary to my comment #1, Android no longer needs support for platformEventTime, which is why it no longer appears in the patch.
Comment 5 Jeremy Orlow 2010-03-11 07:14:54 PST
Comment on attachment 50402 [details]
Proposed Patch.

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 55774)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,24 @@
> +2010-03-10  Ben Murdoch  <benm@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Android] The platform touch events on Android are missing support
> +        for key modifiers.
> +        https://bugs.webkit.org/show_bug.cgi?id=35521
> +
> +        Add support in PlatformToucHEventAndroid for the platform supplying
> +        key modifiers with touch events.
> +
> +        Exisiting touch events test suffice.

Change this to say that you're making existing tests work that didn't before.
Comment 6 Ben Murdoch 2010-03-11 07:28:53 PST
Landed as r55843.